This drop-down menu is used to filter the lab variable that is displayed in the chart. The default measure is set to the first variable in the data set, but the default value can be adjusted to any measure upon the project team's request. Users can select any pre-defined measure in this filter. Selecting a measure will display the data points associated with that measure and will display the visits that the measure is collected at underneath the chart.
The chart can be configured to have any number of data filters. Each specified filter has a drop-down menu that is used to filter the visit data that is displayed in the chart.
Displayed under the header, this statement provides the total number of participants in the data set in integers as well as the percentage of participants shown to one decimal place. In the default view, all participant data is included in the chart, or 100%, unless the project team requests otherwise. When filters are used, the data shown in the histogram is manipulated and the number of participant records shown at the top of the page may increase or decrease, depending on the variable selected.
The chart contains a toggle that controls the display of the x-axis. Users can view the x-axis data by study day, visit, or visit number. The x-axis displays the data point at which the measure data is collected and manipulating it changes the scale at which the measure data is plotted. Study day, visit, or visit number can be chosen for a given measure, but the chart default is to show the x-axis by study day.
Users are able to adjust the lower limit of the y-axis by manipulating the input within the Lower Limit box. Users are able to adjust the upper limit of the y-axis by manipulating the input within the Upper Limit box. Each limit box has up and down arrows to adjust the value of the box by 1. Users can select an arrow to change the input or delete the current value in the box and type in a new value. When typing in a value, users must click outside of the box to apply the changes. When a user manipulates a y-axis limit, the y-axis on the chart below the controls will reflect the change.
Users can change the upper and lower y-axis limits back to the default values for a measure by selecting the "Reset Limits" button. Pressing the button will erase the current values in the upper and lower limit boxes and replace them with defaults. The chart below will also reflect the changes and will show the default axes.
Users can opt to change the method for the normal ranges to the following options: None, LLN-ULN, Standard Deviation, and Quantiles. The default for the normal range controls is set to "LLN-ULN", which is the upper and lower normal range specified in the data. Users may select "None", which will remove the green shading around the normal ranges and will remove the inlier count to the left of the charts. Users may also select "Standard Deviation", which will prompt the user to enter the number of standard deviations they would like to set as the normal range. Altering the default value will change the upper and lower normal range bands in the chart and will change the inlier count to the left of the chart. Users may also select "Quantiles", which prompts the user to enter an upper and lower quantile to set as the normal ranges. Altering the upper quantile will change the upper normal range band in the chart and altering the lower quantile will change the lower normal range band in the chart. Changing the normal ranges may change the number of inliers and the inlier count to the left of the chart will update based on your selections.
Users can select the checkbox to view visits that do not contain data. Checking the box will show a timepoint for the visit. Unchecking the checkbox will hide the timepoint for visits without data; visits without data are hidden on default.
Users can select the checkbox to view data that is not associated with a scheduled visit. Checking the box will show a timepoint for the unscheduled visit and its associated data. Unselecting the checkbox will hide the unscheduled visit timepoint and its data; unscheduled visits are hidden on default.
Clicking a data point will open a listing of small multiples below the chart that contains a detailed listing of all of the participant's records. This linked table contains small charts for each measure captured in the data set as well as the participant's subject ID, age, sex, and race. When the listing appears, the data points selected will appear in a continuous gray line inside of the chart. When a user clicks outside of the selected data point, the gray line disappears along with the detailed listing.
Clicking a data point will perform 2 actions:
Warnings and Notes
Highlighting
The Safety Outlier Explorer is initialized with JSON data files that match the format created by d3.csv(). The chart expects an ADaM-esque data structure by default but can be customized to work with any dataset that contains one row per participant per time point per measure and includes the required columns specified below.
The following columns are expected in a data file used to create an instance of the safety outlier explorer. A sample chart using this configuration is found here.
Settings Variable | Description | Default | Required? |
---|---|---|---|
id_col | Unique Subject Identifier | USUBJID | Y |
timecols[0].valuecol | Visit Name | VISIT | Y |
timecols[0].ordercol | Visit Name (N) | VISITNUM | |
timecols[1].valuecol | Study Day of Visit | DY | |
measure_col | Name of Measure or Test | TEST | Y |
value_col | Result or Finding | STRESN | Y |
unit_col | Units | STRESU | |
normalcollow | Normal Range Lower Limit | STRNLO | |
normalcolhigh | Normal Range Upper Limit | STRNHI | |
details[0].value_col | Age | AGE | |
details[1].value_col | Sex | SEX | |
details[2].value_col | Race | RACE |
No customization is needed to initialize a chart when the data
object contains all default variables above.
Just pass an empty object ({}
) for settings
and initialize the chart like so: safetyOutlierExplorer('body', {}).init(data)
.
The following data specs and chart settings can be used to create a chart with several custom filters, including Sex, Race and Query Status. A sample chart using this configuration is found here.
Settings Variable | Description | Default | Required? |
---|---|---|---|
id_col | Unique Subject Identifier | USUBJID | Y |
timecols[0].valuecol | Visit Name | VISIT | Y |
timecols[0].ordercol | Visit Name (N) | VISITNUM | |
timecols[1].valuecol | Study Day of Visit | DY | |
measure_col | Name of Measure or Test | TEST | Y |
value_col | Result or Finding | STRESN | Y |
unit_col | Units | STRESU | |
normalcollow | Normal Range Lower Limit | STRNLO | |
normalcolhigh | Normal Range Upper Limit | STRNHI | |
details[0].value_col | Age | AGE | |
details[1].value_col | Sex | SEX | |
details[2].value_col | Race | RACE | |
filter | Site ID | SITEID | Y |
filter | Treatment Arm | ARM | Y |
filter | Sex | SEX | Y |
filter | Race | RACE | Y |
filter | Query Flag ("Y" for yes) | QUERYFL | Y |
custom_marks[0].tooltip | Query Details | QUERYDETAILS | Y |
{
time_cols: [
{
value_col: 'VISIT',
type: 'ordinal',
label: 'Visit',
rotate_tick_labels: true,
vertical_space: 100,
order_col: 'VISITNUM'
},
{
value_col: 'DY',
type: 'linear',
label: 'Study Day',
rotate_tick_labels: false,
vertical_space: 0
}
],
filters: [
{value_col: 'ARM', label: 'Arm'},
{value_col: 'SITEID', label: 'Site ID'},
{value_col: 'SEX', label: 'Sex'},
{value_col: 'RACE', label: 'Race'},
{value_col: 'QUERYFL', label: 'Open Query?'}
],
details: [
{value_col: 'ARM', label: 'Arm'},
{value_col: 'AGE', label: 'Age'},
{value_col: 'SEX', label: 'Sex'},
{value_col: 'RACE', label: 'Race'}
],
custom_marks: [
{
per: ['USUBJID', 'VISIT', 'STRESN'],
type: 'circle',
attributes: {
'fill-opacity': 1,
'stroke': 'red',
'fill': 'red'
},
values: {
QUERYFL: ['Y']
},
tooltip: 'Query Details: [QUERYDETAILS]'
}
],
multiples_sizing: {
width: 250,
height: 75
}
}
a factory to create a custom Webcharts chart object
returns: chart
Param | Type | Description |
---|---|---|
element | string |
CSS selector identifying the element in which to create the chart |
settings | object |
settings object specifying options for how the chart is to appear and behave. Options defined here overwrite default values; see Configuration |
The custom participantsSelected
event is dispatched to the overall chart wrapper (chart.wrap
) whenever the details for a given participant are viewed (or cleared) by clicking on a line or point in the chart. The event has a custom data
property holding an array with the selected ID when a new participant is selected (["123-456-7"]
) or an empty array when participant details are cleared.
The most straightforward way to customize the Safety Outlier Explorer is by using a configuration object whose properties describe the behavior and appearance of the chart. Since the Safety Outlier Explorer is a Webcharts chart
object, many default Webcharts settings are set in the defaultSettings.js file as described below. Refer to the Webcharts documentation for more details on these settings.
In addition to the standard Webcharts settings several custom settings not available in the base Webcharts library have been added to the Safety Outlier Explorer to facilitate data mapping and other custom functionality. These custom settings are described in detail below. All defaults can be overwritten by users.
The sections below describe each safety-outlier-explorer setting as of version 2.3.0.
string
unique identifier variable name
default: "USUBJID"
array
visit metadata
default:
[
{
"type": "ordinal",
"value_col": "VISIT",
"label": "Visit",
"order_col": "VISITNUM",
"order": null,
"rotate_tick_labels": true,
"vertical_space": 100
},
{
"type": "linear",
"value_col": "DY",
"label": "Study Day",
"order_col": "DY",
"order": null,
"rotate_tick_labels": false,
"vertical_space": 0
}
]
string
Visit variable data type
default: "ordinal"
string
Visit variable name
default: "VISIT"
string
Visit variable label
default: "Visit"
string
Visit ordering variable name
default: "VISITNUM"
array
Visit order
default: none
boolean
Rotate tick labels 45 degrees?
default: true
number
Rotated tick label spacing
default: 100
string
measure variable name
default: "TEST"
string
measure unit variable name
default: "STRESU"
string
result variable name
default: "STRESN"
string
LLN variable name
default: "STNRLO"
string
ULN variable name
default: "STNRHI"
string
value of measure to display initially
default: none
array
an array of filter variables and associated metadata
default: none
string
Variable name
default: none
string
Variable label
default: none
array
an array of ID-level variables and associated metadata
default:
[
{
"value_col": "AGE",
"label": "Age"
},
{
"value_col": "SEX",
"label": "Sex"
},
{
"value_col": "RACE",
"label": "Race"
}
]
string
Variable name
default: "AGE"
string
Variable label
default: "Age"
object
added in v2.4. Takes an array of col/label objects and adds those values to the end of the standard point tooltips. The following would add Date to the tooltip: {tooltip_cols: [{label:"Date",value_col:"DT"}]};
default: null
object
width and height of small multiples
number
Width
default: 300
number
Height
default: 100
string
method for identifying the normal range
default: "LLN-ULN"
number
the number of standard deviations from the mean with which to define the normal range
default: 1.96
number
this quantile defines the lower bound of the normal range
default: 0.05
number
this quantile defines the upper bound of the normal range
default: 0.95
boolean
controls display of visits without data for the current measure
default: false
boolean
controls display of unscheduled visits
default: false
string
a regular expression that identifies unscheduled visits
default: "/unscheduled|early termination/i"
array
an array of strings that identify unscheduled visits; overrides unscheduledvisitpattern
default: none
object
an object that defines the line color, thickness, and opacity
string
Line Color
default: "black"
number
Line Thickness
default: 0.5
number
Line Opacity
default: 0.75
object
an object that defines the point color, radius, and opacity and its outline color, thickness, and opacity
string
Point Outline Color
default: "rgb(102,194,165)"
number
Point Outline Thickness
default: 0.5
number
Point Outline Opacity
default: 1
string
Point Color
default: "rgb(102,194,165)"
number
Point Radius
default: 3
number
Point Opacity
default: 1
The object below contains each Webcharts setting as of version 2.3.0.
{
x: {
column: null, //set in syncSettings()
type: null, //set in syncSettings()
behavior: 'raw'
},
y: {
column: null, //set in syncSettings()
stat: 'mean',
type: 'linear',
label: 'Value',
behavior: 'raw',
format: '0.2f'
},
marks: [
{
per: null, //set in syncSettings()
type: 'line',
attributes: {
'clip-path': 'url(#1)'
},
tooltip: null //set in syncSettings()
},
{
per: null, //set in syncSettings()
type: 'circle',
attributes: {
'clip-path': 'url(#1)'
},
tooltip: null //set in syncSettings()
}
],
resizable: true,
margin: { right: 20 }, //create space for box plot
aspect: 3
}
PullRequest | Requester | DateRequested | Branch | Target | Title | ReviewID | Reviewer | ReviewDate | ReviewStatus | MergedBy | DateMerged | ReviewComments |
---|---|---|---|---|---|---|---|---|---|---|---|---|
0007 | jwildfire | 2016-04-15T16:34:39Z | adjust-ticks | master | Adjust ticks | NONE | jwildfire | 2016-04-15T16:34:47Z | ||||
0014 | jwildfire | 2016-05-25T19:55:47Z | reorg | master | Reorg | NONE | Nathan Bryant | 2016-06-08T14:45:25Z | ||||
0015 | nbryant | 2016-06-14T17:17:40Z | build-fix | master | fixing build to use babel | NONE | jwildfire | 2016-06-14T17:42:24Z | ||||
0026 | jwildfire | 2016-12-17T16:15:37Z | v1.3.0 | master | Safety Outlier Explorer v1.3.0 | NONE | jwildfire | 2017-02-23T22:03:03Z | ||||
0028 | samussiah | 2017-01-09T17:39:14Z | custom-filters | v1.3.0 | Implement custom filter functionality and update build-chf process. | 16036262 | jwildfire | 2017-01-10T23:16:45Z | CHANGES_REQUESTED | Spencer Childress | 2017-01-20T14:28:14Z | I'd suggest avoiding this hard code and working time_col[].type in to the settings so that the user can specify what type of axis to use. See [here](https://github.com/RhoInc/safety-outlier-explorer/pull/32#pullrequestreview-16034578) for details. |
0028 | samussiah | 2017-01-09T17:39:14Z | custom-filters | v1.3.0 | Implement custom filter functionality and update build-chf process. | 16239688 | samussiah | 2017-01-11T21:27:17Z | COMMENTED | Spencer Childress | 2017-01-20T14:28:14Z | Fixed in #32 |
0028 | samussiah | 2017-01-09T17:39:14Z | custom-filters | v1.3.0 | Implement custom filter functionality and update build-chf process. | 17485238 | jwildfire | 2017-01-19T15:47:49Z | COMMENTED | Spencer Childress | 2017-01-20T14:28:14Z | Looks good. Careful with the order of the PR merges. LMK if you start hitting problems. |
0028 | samussiah | 2017-01-09T17:39:14Z | custom-filters | v1.3.0 | Implement custom filter functionality and update build-chf process. | 17485251 | jwildfire | 2017-01-19T15:47:52Z | APPROVED | Spencer Childress | 2017-01-20T14:28:14Z | |
0029 | samussiah | 2017-01-09T20:06:04Z | participant-details | v1.3.0 | Add participant details to small multiples container. | 15937822 | jwildfire | 2017-01-10T15:22:20Z | APPROVED | Spencer Childress | 2017-01-20T14:46:09Z | 👍 looks good to me. Ready to merge. |
0030 | samussiah | 2017-01-10T15:39:40Z | small-multiple-layout | v1.3.0 | Remove small multiple resizability to improve layout. | 16038309 | jwildfire | 2017-01-10T23:29:37Z | APPROVED | Spencer Childress | 2017-01-20T16:10:42Z | Looking good. Default is a tad small for multiples; worth adding a setting for smallMultipleWidth? |
0031 | samussiah | 2017-01-10T16:53:59Z | consistent-axes | v1.3.0 | Implement consistent axes within a selected measure when other filter… | 16037412 | jwildfire | 2017-01-10T23:24:05Z | CHANGES_REQUESTED | Spencer Childress | 2017-01-20T14:51:20Z | Like this approach a lot. One more change related to generalizing the hard code logic for the x axis;;Another change like [this one](https://github.com/RhoInc/safety-outlier-explorer/pull/32#pullrequestreview-16034578) needed :( Should be able to pull the axis type off of `config.time_col[].type` and then decide whether to use `d3.extent()` or `d3.set().values()` based on that. |
0031 | samussiah | 2017-01-10T16:53:59Z | consistent-axes | v1.3.0 | Implement consistent axes within a selected measure when other filter… | 16239621 | samussiah | 2017-01-11T21:26:54Z | COMMENTED | Spencer Childress | 2017-01-20T14:51:20Z | Fixed in #32 |
0031 | samussiah | 2017-01-10T16:53:59Z | consistent-axes | v1.3.0 | Implement consistent axes within a selected measure when other filter… | 17486009 | jwildfire | 2017-01-19T15:50:54Z | COMMENTED | Spencer Childress | 2017-01-20T14:51:20Z | Looks good. Careful with merge order. |
0031 | samussiah | 2017-01-10T16:53:59Z | consistent-axes | v1.3.0 | Implement consistent axes within a selected measure when other filter… | 17486027 | jwildfire | 2017-01-19T15:50:58Z | APPROVED | Spencer Childress | 2017-01-20T14:51:20Z | |
0032 | samussiah | 2017-01-10T19:20:42Z | rotate-x-tick-labels | v1.3.0 | Add x-axis tick label rotation functionality with setting... | 16034578 | jwildfire | 2017-01-10T23:05:55Z | CHANGES_REQUESTED | Spencer Childress | 2017-01-20T15:02:03Z | I'm a little worried about having a hard coded variable name here ("DY"). What happens when the user specifies a different set of `time_cols`? ;; ;; What if we had time_cols specified like this: `time_cols: [{value_col:"VISITN", axis_type:"ordinal"}, {value_col:"DY", axis_type:"linear}, ...]`, then this area becomes:;; ```;; settings.x.column = settings.time_cols[0].value_col;;; settings.x.type = settings.time_cols[0].axis_type;;; ``` |
0032 | samussiah | 2017-01-10T19:20:42Z | rotate-x-tick-labels | v1.3.0 | Add x-axis tick label rotation functionality with setting... | 16037986 | samussiah | 2017-01-10T23:27:29Z | COMMENTED | Spencer Childress | 2017-01-20T15:02:03Z | I like that approach a helluva lot more. |
0032 | samussiah | 2017-01-10T19:20:42Z | rotate-x-tick-labels | v1.3.0 | Add x-axis tick label rotation functionality with setting... | 17484963 | jwildfire | 2017-01-19T15:46:44Z | APPROVED | Spencer Childress | 2017-01-20T15:02:03Z | Looks great. Well done. |
0033 | samussiah | 2017-01-10T21:31:52Z | sample-population | v1.3.0 | Add sample/population annotation. | 16032313 | jwildfire | 2017-01-10T22:50:48Z | COMMENTED | Spencer Childress | 2017-01-20T15:12:11Z | Why do we need super_raw_data instead of just the normal raw_data here? ;; ;; I see that convention quite a bit. Maybe we should just add it to webcharts? |
0033 | samussiah | 2017-01-10T21:31:52Z | sample-population | v1.3.0 | Add sample/population annotation. | 16032402 | jwildfire | 2017-01-10T22:51:25Z | COMMENTED | Spencer Childress | 2017-01-20T15:12:11Z | Looks good - just one question about super_raw for you. |
0033 | samussiah | 2017-01-10T21:31:52Z | sample-population | v1.3.0 | Add sample/population annotation. | 16239290 | samussiah | 2017-01-11T21:25:15Z | COMMENTED | Spencer Childress | 2017-01-20T15:12:11Z | Updated to calculate population count onInit() instead of passing around an unadulterated data array. |
0033 | samussiah | 2017-01-10T21:31:52Z | sample-population | v1.3.0 | Add sample/population annotation. | 17486648 | jwildfire | 2017-01-19T15:53:14Z | APPROVED | Spencer Childress | 2017-01-20T15:12:11Z | |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17487955 | jwildfire | 2017-01-19T15:57:57Z | COMMENTED | Spencer Childress | 2017-01-20T16:03:34Z | This probably won't work since the `unit_col` typically changes with `measure_col` |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17488232 | jwildfire | 2017-01-19T15:59:09Z | COMMENTED | Spencer Childress | 2017-01-20T16:03:34Z | might need something like `raw_data.filter(d=>give me the current measure)[0][chart.config.unit_col]` |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17488380 | jwildfire | 2017-01-19T15:59:40Z | COMMENTED | Spencer Childress | 2017-01-20T16:03:34Z | we should really clean up the data paradigm in webcharts a bit ... let's make time for that after these releases go out. |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17488727 | jwildfire | 2017-01-19T16:00:59Z | COMMENTED | Spencer Childress | 2017-01-20T16:03:34Z | Need to only look at the currently selected measure here. see comment above for possible implementation. |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17489594 | jwildfire | 2017-01-19T16:04:36Z | COMMENTED | Spencer Childress | 2017-01-20T16:03:34Z | For the moment, maybe we should create/maintain a `chart.measure_data` in this renderer. Seems like that would deal with most of this nonsense in a fairly elegant way ... just throw something like this in to `onInit()` and `onDraw()`:;; ;; ```;; var current_measure = {go get it from the control};; chart.measure_data = raw_data.filter(d=>d[chart.config.measure_col]==current_measure);; ``` |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17489992 | jwildfire | 2017-01-19T16:06:03Z | COMMENTED | Spencer Childress | 2017-01-20T16:03:34Z | Yessiree. Like this a lot. |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17490118 | jwildfire | 2017-01-19T16:06:30Z | DISMISSED | Spencer Childress | 2017-01-20T16:03:34Z | See comments about creating `chart.summary_data` to help with data flow in this renderer. |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17705172 | samussiah | 2017-01-20T15:56:15Z | COMMENTED | Spencer Childress | 2017-01-20T16:03:34Z | @jwildfire `this.raw_data` in this case refers to an individual multiple's data, which is already filtered on a single measure. The reason I switched from `this.current_data` eludes me but it is simpler to pull a datum out of `this.raw_data`. |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17705533 | samussiah | 2017-01-20T15:57:51Z | COMMENTED | Spencer Childress | 2017-01-20T16:03:34Z | Similarly, `chart.raw_data` refers to the multiple's data, which is already filtered on a single measure. |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17709913 | samussiah | 2017-01-20T16:17:16Z | COMMENTED | Spencer Childress | 2017-01-20T16:03:34Z | Just kidding, you're absolutely right. Will update to `this.filtered_data` in a new branch. |
0034 | samussiah | 2017-01-17T20:19:05Z | custom-marks | v1.3.0 | Custom marks | 17709930 | samussiah | 2017-01-20T16:17:20Z | COMMENTED | Spencer Childress | 2017-01-20T16:03:34Z | Just kidding, you're absolutely right. Will update to `this.filtered_data` in a new branch. |
0038 | samussiah | 2017-01-20T22:26:39Z | small-multiple-fixes | v1.3.0 | Add configuration of and variable y-domain to small multiples. | 18065992 | jwildfire | 2017-01-24T01:18:52Z | CHANGES_REQUESTED | Spencer Childress | 2017-01-25T18:09:31Z | Looks great in general. Just take a look at the highlight on point click. ;;Clicking a line gives the expected behaviour, but clicking a point (that is a |
0038 | samussiah | 2017-01-20T22:26:39Z | small-multiple-fixes | v1.3.0 | Add configuration of and variable y-domain to small multiples. | 18464455 | samussiah | 2017-01-25T18:09:15Z | COMMENTED | Spencer Childress | 2017-01-25T18:09:31Z | Fixed. |
0044 | samussiah | 2017-02-02T15:26:52Z | y-axis-label-fix | v1.3.0 | Fixing small multiples y-axis label issue. | 21894300 | jwildfire | 2017-02-14T23:45:04Z | APPROVED | jwildfire | 2017-02-14T23:45:17Z | Looks good. |
0045 | jwildfire | 2017-02-23T21:46:07Z | master | v1.3.0 | Update 2.0 from master | NONE | ||||||
0047 | jwildfire | 2017-03-07T02:34:13Z | v2.0.1 | master | no filters for 0 or 1 level vars. closes #46 | 25649265 | samussiah | 2017-03-07T22:26:07Z | APPROVED | jwildfire | 2017-03-13T23:34:28Z | Nooice! |
0052 | jwildfire | 2017-10-12T22:53:20Z | v2.0.2-dev | master | v2.0.2 - dev branch | 69263322 | samussiah | 2017-10-13T15:22:03Z | APPROVED | jwildfire | 2017-10-13T21:00:35Z | |
0055 | jwildfire | 2017-10-16T20:12:56Z | v2.0.3-dev | master | V2.0.3 dev | 69687382 | samussiah | 2017-10-16T20:23:09Z | APPROVED | Spencer Childress | 2017-10-16T20:30:43Z | |
0059 | jwildfire | 2017-11-17T03:03:17Z | y-axis-controls | v2.1.0-dev | Y axis controls | 77471728 | samussiah | 2017-11-17T15:41:40Z | COMMENTED | Spencer Childress | 2017-11-17T15:42:53Z | Smart. |
0059 | jwildfire | 2017-11-17T03:03:17Z | y-axis-controls | v2.1.0-dev | Y axis controls | 77471863 | samussiah | 2017-11-17T15:42:04Z | APPROVED | Spencer Childress | 2017-11-17T15:42:53Z | Entirely functional, I likes! |
0060 | jwildfire | 2017-11-17T03:04:07Z | v2.1.0-dev | master | v2.1.0 Development Branch | 81204300 | brittsikora | 2017-12-05T14:40:53Z | APPROVED | Spencer Childress | 2017-12-05T14:47:48Z | Passed regression testing |
0061 | jwildfire | 2017-11-17T03:49:06Z | check-values | v2.1.0-dev | Don't drop measures with sparse numeric data | 79912316 | samussiah | 2017-11-29T16:35:06Z | CHANGES_REQUESTED | Spencer Childress | 2017-12-04T00:46:44Z | `+"" === 0`;; ;; I'd prefer to kick out missing values. |
0065 | samussiah | 2017-12-05T18:00:02Z | y-axis-controls | master | refactor y-axis controls | 81281130 | jwildfire | 2017-12-05T18:06:45Z | APPROVED | jwildfire | 2017-12-05T18:08:53Z | Works like a charm. I like the updated labels |
0073 | samussiah | 2018-01-26T20:03:40Z | v2.2.0-dev | master | Safety Outlier Explorer - v2.2.0 | 93729014 | brittsikora | 2018-02-02T19:24:45Z | APPROVED | samussiah | 2018-02-02T21:34:30Z | Passing regression testing in firefox and chrome |
0074 | samussiah | 2018-01-26T20:04:24Z | visit-order | v2.2.0-dev | Visit order | 92058104 | jwildfire | 2018-01-28T17:01:08Z | APPROVED | Spencer Childress | 2018-02-01T22:11:57Z | Very nice - thanks for all the refactor work. ;;any specific reason to move it to preprocess? Or just trying to keep everything together? ;;Seems like this should be in #76 - Is `config.unscheduled_visits` defined yet? No biggie though. I assume this will be used in the later PRs. ;;Nice refactor here 🥇 ;;more code for #76 ? ;;I think we should make this warning visible at some point. Make it a footnote or something instead of showing it just in the console. Created #79 for later. ;;NBD, but curious if there is a reason for the funky "|" concatenation here instead of just using an object with 2 properties? ;; ;;another refactor 🏅 - you'll catch Michael Phelps in no time. ;;We should probably make an issue to fix this in webcharts. ;;Hate having to re-write the filter functionality here - I think it's slightly cleaner to filter `raw_data` based on the measure, and save the actual raw data in `super_raw` in the init callback. That way the regular webcharts filtering workflow still works. Maybe not worth fixing in v2.2 (since I'm sure this works fine), but something to keep in mind for later. ;; ;; If we ever do decide to tackle webcharts v2.0 I definitely think that we should add a `preprocessed_data` array (or something like that) to the chart object. That new array would sits between the loaded data and the data that is sent to `webcharts.draw()`. |
0074 | samussiah | 2018-01-26T20:04:24Z | visit-order | v2.2.0-dev | Visit order | 92243465 | samussiah | 2018-01-29T15:34:49Z | COMMENTED | Spencer Childress | 2018-02-01T22:11:57Z | Because it's a pain to modify `current_data`, particularly when there's more than one mark type. Simpler to modify the raw data, hence `initial_data`, `measure_data`, etc. |
0074 | samussiah | 2018-01-26T20:04:24Z | visit-order | v2.2.0-dev | Visit order | 92243647 | samussiah | 2018-01-29T15:35:19Z | COMMENTED | Spencer Childress | 2018-02-01T22:11:57Z | Rightio. Just copying stuff from the safety-results-over-time updates. |
0074 | samussiah | 2018-01-26T20:04:24Z | visit-order | v2.2.0-dev | Visit order | 92243766 | samussiah | 2018-01-29T15:35:41Z | COMMENTED | Spencer Childress | 2018-02-01T22:11:57Z | Heh yeah. |
0074 | samussiah | 2018-01-26T20:04:24Z | visit-order | v2.2.0-dev | Visit order | 92244012 | samussiah | 2018-01-29T15:36:17Z | COMMENTED | Spencer Childress | 2018-02-01T22:11:57Z | Not a bad idea, perhaps a red exclamation point with a tooltip. |
0074 | samussiah | 2018-01-26T20:04:24Z | visit-order | v2.2.0-dev | Visit order | 92244206 | samussiah | 2018-01-29T15:36:49Z | COMMENTED | Spencer Childress | 2018-02-01T22:11:57Z | Because I don't think `d3.set()` works with objects? Could be wrong about that. |
0074 | samussiah | 2018-01-26T20:04:24Z | visit-order | v2.2.0-dev | Visit order | 92244454 | samussiah | 2018-01-29T15:37:28Z | COMMENTED | Spencer Childress | 2018-02-01T22:11:57Z | It would be nice to identify controls without accessing their data. |
0074 | samussiah | 2018-01-26T20:04:24Z | visit-order | v2.2.0-dev | Visit order | 92249110 | samussiah | 2018-01-29T15:48:46Z | COMMENTED | Spencer Childress | 2018-02-01T22:11:57Z | You're right, we don't even need this data array.;; ;; The issue here is that we want only the measure filter to change the domains. It'd be nice to specify in the filter settings the x- and y-behavior. What do you think?;; ;; This bit does seem over-engineered though. If we just set the behaviors to raw and set `raw_data` to the `measure_data` we can avoid defining the filtered data and domains.;; ;; It'd be nice if we could access the data between each of these steps:;; ;; 1. raw data;; 2. valid data, removing x- and y-values that don't make sense;; 3. filtered data, applying the filters;; 4. mark data, nesting the data |
0074 | samussiah | 2018-01-26T20:04:24Z | visit-order | v2.2.0-dev | Visit order | 93308123 | brittsikora | 2018-02-01T14:55:03Z | APPROVED | Spencer Childress | 2018-02-01T22:11:57Z | |
0076 | samussiah | 2018-01-26T21:48:00Z | unscheduled-visits | v2.2.0-dev | Unscheduled visits | 92089934 | jwildfire | 2018-01-29T04:38:22Z | APPROVED | Spencer Childress | 2018-02-01T22:12:17Z | Looks good to me. ;; ;; (Just reviewed afc1f9ab433df480fe90031a75430652711632d2);;This lives elsewhere now??;;Moved in refactor? ;;`array.pop()` instead of `array[0]` is cute. Probably a bit easier to read. ;;How dare you use `chart.initial_data` instead of good ol' `chart.super_raw_data`? Kids these days. ;;Guessing this wasn't be used? |
0076 | samussiah | 2018-01-26T21:48:00Z | unscheduled-visits | v2.2.0-dev | Unscheduled visits | 92241069 | samussiah | 2018-01-29T15:28:38Z | COMMENTED | Spencer Childress | 2018-02-01T22:12:17Z | Changed it to updateParticipantCount ¯\_(ツ)_/¯ |
0076 | samussiah | 2018-01-26T21:48:00Z | unscheduled-visits | v2.2.0-dev | Unscheduled visits | 92241335 | samussiah | 2018-01-29T15:29:20Z | COMMENTED | Spencer Childress | 2018-02-01T22:12:17Z | Moved to `onPreprocess/setYdomain`. |
0076 | samussiah | 2018-01-26T21:48:00Z | unscheduled-visits | v2.2.0-dev | Unscheduled visits | 92242252 | samussiah | 2018-01-29T15:31:36Z | COMMENTED | Spencer Childress | 2018-02-01T22:12:17Z | Yeah, but [`array.find()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find) is the best option, but the one time I tried it out babel didn't add a polyfill so it failed in IE. |
0076 | samussiah | 2018-01-26T21:48:00Z | unscheduled-visits | v2.2.0-dev | Unscheduled visits | 92242534 | samussiah | 2018-01-29T15:32:21Z | COMMENTED | Spencer Childress | 2018-02-01T22:12:17Z | I'm not a super freak. |
0076 | samussiah | 2018-01-26T21:48:00Z | unscheduled-visits | v2.2.0-dev | Unscheduled visits | 92242755 | samussiah | 2018-01-29T15:32:55Z | COMMENTED | Spencer Childress | 2018-02-01T22:12:17Z | Right, only needed that in safety-results-over-time for the box plots. |
0076 | samussiah | 2018-01-26T21:48:00Z | unscheduled-visits | v2.2.0-dev | Unscheduled visits | 93332460 | brittsikora | 2018-02-01T15:56:10Z | APPROVED | Spencer Childress | 2018-02-01T22:12:17Z | |
0077 | samussiah | 2018-01-26T22:04:27Z | visits-without-data | master | Visits without data | 92091177 | jwildfire | 2018-01-29T04:47:26Z | APPROVED | Spencer Childress | 2018-02-01T22:12:30Z | Easy peasy. ;; ;; (Just reviewed bcc71207c005f0f28a88cf11365abfd0112ad94d here) |
0077 | samussiah | 2018-01-26T22:04:27Z | visits-without-data | master | Visits without data | 93306717 | brittsikora | 2018-02-01T14:51:24Z | APPROVED | Spencer Childress | 2018-02-01T22:12:30Z | Pass, nice job! |
0078 | samussiah | 2018-01-26T22:27:45Z | settings-schema | master | Settings schema | 92091598 | jwildfire | 2018-01-29T04:53:42Z | APPROVED | Spencer Childress | 2018-02-01T22:12:45Z | oopsies. |
0078 | samussiah | 2018-01-26T22:27:45Z | settings-schema | master | Settings schema | 93336906 | brittsikora | 2018-02-01T16:06:45Z | APPROVED | Spencer Childress | 2018-02-01T22:12:45Z | Broken in firefox, but works in chrome in the CAT. Will not be an issue outside of the CAT |
0081 | samussiah | 2018-02-01T22:14:05Z | revert-78-settings-schema | master | Revert "Settings schema" | NONE | Spencer Childress | 2018-02-01T22:14:14Z | ||||
0082 | samussiah | 2018-02-01T22:15:02Z | revert-77-visits-without-data | master | Revert "Visits without data" | NONE | Spencer Childress | 2018-02-01T22:15:08Z | ||||
0083 | samussiah | 2018-02-01T22:18:35Z | visits-without-data | v2.2.0-dev | Visits without data | NONE | Spencer Childress | 2018-02-01T22:18:41Z | ||||
0084 | samussiah | 2018-02-01T22:20:20Z | settings-schema | v2.2.0-dev | Settings schema | NONE | Spencer Childress | 2018-02-01T22:20:30Z | ||||
0085 | samussiah | 2018-02-02T22:07:32Z | v2.2.1-dev | master | messed up npm publish so updating the patch version | NONE | Spencer Childress | 2018-02-02T22:07:43Z | ||||
0087 | samussiah | 2018-02-27T14:56:09Z | v2.2.3-dev | master | Safety Outlier Explorer - v2.2.3 | 100109077 | pburnsdata | 2018-02-28T15:34:37Z | APPROVED | samussiah | 2018-03-09T20:24:21Z | |
0087 | samussiah | 2018-02-27T14:56:09Z | v2.2.3-dev | master | Safety Outlier Explorer - v2.2.3 | 102770317 | dschwentker | 2018-03-09T19:56:54Z | APPROVED | samussiah | 2018-03-09T20:24:21Z | Tested and passed using webcharts version v1.10.0-dev. Confirmed that there are 0 results when running d3.selectAll('.wc-controls .control-label') in the console. |
0089 | samussiah | 2018-03-27T13:39:27Z | v2.3.0-dev | master | Safety Outlier Explorer v2.3.0 | 114456493 | tmbarald | 2018-04-23T16:19:49Z | APPROVED | Spencer Childress | 2018-04-27T18:16:18Z | Gotcha @samussiah . All good now! |
0092 | samussiah | 2018-03-28T15:48:25Z | darker-lines | v2.3.0-dev | Darker lines | 108142079 | pburnsdata | 2018-03-29T17:45:27Z | CHANGES_REQUESTED | Spencer Childress | 2018-04-16T19:12:55Z | It's darker! Looks good, only concern is that because points have outlines around them now, they are getting obscured sometimes by points around them. ;; ;; ![image](https://user-images.githubusercontent.com/26064686/38103003-0be8d476-3353-11e8-808e-64a17d1fb843.png);; Maybe sending them to the front with something like this when they are selected would make sense: ;; ;; d3.selection.prototype.moveToFront = function() {;; return this.each(function() {;; this.parentNode.appendChild(this);;; });;; };;; ;; (from https://github.com/wbkd/d3-extended) |
0092 | samussiah | 2018-03-28T15:48:25Z | darker-lines | v2.3.0-dev | Darker lines | 110117922 | pburnsdata | 2018-04-06T15:57:08Z | APPROVED | Spencer Childress | 2018-04-16T19:12:55Z | |
0092 | samussiah | 2018-03-28T15:48:25Z | darker-lines | v2.3.0-dev | Darker lines | 112072704 | tmbarald | 2018-04-13T16:14:49Z | APPROVED | Spencer Childress | 2018-04-16T19:12:55Z | Issue fixed on all browsers |
0093 | samussiah | 2018-03-30T18:51:27Z | normal-range-controls | v2.3.0-dev | Normal range controls | 109115979 | pburnsdata | 2018-04-03T21:02:46Z | APPROVED | Spencer Childress | 2018-04-16T19:36:29Z | |
0093 | samussiah | 2018-03-30T18:51:27Z | normal-range-controls | v2.3.0-dev | Normal range controls | 112016452 | tmbarald | 2018-04-13T13:47:03Z | APPROVED | Spencer Childress | 2018-04-16T19:36:29Z | Worked well in all browsers. Found minor bug that was only in IE. |
0094 | samussiah | 2018-03-30T19:24:53Z | fix-tick-rotation | v2.3.0-dev | Fix tick rotation | 109442362 | pburnsdata | 2018-04-04T18:16:30Z | APPROVED | samussiah | 2018-04-16T19:36:30Z | |
0094 | samussiah | 2018-03-30T19:24:53Z | fix-tick-rotation | v2.3.0-dev | Fix tick rotation | 112030411 | tmbarald | 2018-04-13T14:22:34Z | APPROVED | samussiah | 2018-04-16T19:36:30Z | Issue fixed on all browsers |
0095 | samussiah | 2018-03-30T20:39:52Z | append-units | v2.3.0-dev | Append units | 109445979 | pburnsdata | 2018-04-04T18:26:14Z | APPROVED | Spencer Childress | 2018-04-16T19:41:08Z | |
0095 | samussiah | 2018-03-30T20:39:52Z | append-units | v2.3.0-dev | Append units | 112048916 | tmbarald | 2018-04-13T15:08:45Z | APPROVED | Spencer Childress | 2018-04-16T19:41:08Z | The issue has been fixed for all browsers. |
0098 | samussiah | 2018-04-02T15:15:40Z | add-test-page-script | v2.3.0-dev | add package.json script | NONE | Spencer Childress | 2018-04-16T19:41:19Z | ||||
0102 | brittsikora | 2018-04-25T20:47:33Z | brittsikora-patch-1 | v2.3.0-dev | Updating example link | 116034117 | samussiah | 2018-04-27T18:13:54Z | APPROVED | Spencer Childress | 2018-04-27T18:14:55Z | |
0104 | rtbailey | 2018-08-09T19:44:26Z | rtbailey-patch-1 | v2.4.0-dev | Update LICENSE.md | NONE | jwildfire | 2018-10-03T20:51:14Z | ||||
0108 | jwildfire | 2018-10-03T20:51:30Z | v2.4.0-dev | master | Safety Outlier Explorer v2.4.0 | 163563447 | samussiah | 2018-10-10T21:11:54Z | COMMENTED | jwildfire | 2018-10-29T21:16:55Z | that'll teach Mozilla! |
0108 | jwildfire | 2018-10-03T20:51:30Z | v2.4.0-dev | master | Safety Outlier Explorer v2.4.0 | 163563478 | samussiah | 2018-10-10T21:11:59Z | APPROVED | jwildfire | 2018-10-29T21:16:55Z | |
0108 | jwildfire | 2018-10-03T20:51:30Z | v2.4.0-dev | master | Safety Outlier Explorer v2.4.0 | 169512659 | dschwentker | 2018-10-29T20:53:18Z | APPROVED | jwildfire | 2018-10-29T21:16:55Z | Regression testing run and passed in Chrome and Firefox. |
0110 | jwildfire | 2018-10-04T04:20:15Z | sendToBackOnClick | v2.4.0-dev | Send points to the back on click. #105 | 162905535 | samussiah | 2018-10-09T14:01:22Z | COMMENTED | Spencer Childress | 2018-10-23T18:59:45Z | #pretentious |
0110 | jwildfire | 2018-10-04T04:20:15Z | sendToBackOnClick | v2.4.0-dev | Send points to the back on click. #105 | 162917010 | samussiah | 2018-10-09T14:22:04Z | COMMENTED | Spencer Childress | 2018-10-23T18:59:45Z | That checks out. |
0110 | jwildfire | 2018-10-04T04:20:15Z | sendToBackOnClick | v2.4.0-dev | Send points to the back on click. #105 | 162917888 | samussiah | 2018-10-09T14:23:36Z | APPROVED | Spencer Childress | 2018-10-23T18:59:45Z | That was a lot easier than I expected. Noice! |
0112 | samussiah | 2018-10-10T21:06:13Z | fix-mark-rotation-to-front | sendToBackOnClick | Fix mark rotation to front | 163564354 | samussiah | 2018-10-10T21:14:11Z | COMMENTED | Spencer Childress | 2018-10-23T18:59:32Z | Forgot to update lines. Will fix in the morning. |
0112 | samussiah | 2018-10-10T21:06:13Z | fix-mark-rotation-to-front | sendToBackOnClick | Fix mark rotation to front | 163564582 | samussiah | 2018-10-10T21:14:48Z | COMMENTED | Spencer Childress | 2018-10-23T18:59:32Z | two applications can't hurt right? |
0112 | samussiah | 2018-10-10T21:06:13Z | fix-mark-rotation-to-front | sendToBackOnClick | Fix mark rotation to front | 167072468 | jwildfire | 2018-10-22T19:48:48Z | APPROVED | Spencer Childress | 2018-10-23T18:59:32Z | 🔥 Well done all around. Thanks for all the effort to make my dinky little slapdash update actually work!;; ;; ;;nice touch making this clickable.;;ugh - hate that this is needed to update the radius. we should clean this up in v2.0;;nice code, this is. ;;nicely done;;Nice addition! ⭐️for going above and beyond the spec. ;;Not sure what this bit is doing really ... ;;Is it actually called anywhere else? |
0112 | samussiah | 2018-10-10T21:06:13Z | fix-mark-rotation-to-front | sendToBackOnClick | Fix mark rotation to front | 167085325 | samussiah | 2018-10-22T20:04:35Z | COMMENTED | Spencer Childress | 2018-10-23T18:59:32Z | yeah, this just makes accessing `chart.points` and `chart.lines` more accessible down the line, instead of having to `chart.marks.find(mark => mark.type == 'circle|line').groups` every time they need accessing |
0112 | samussiah | 2018-10-10T21:06:13Z | fix-mark-rotation-to-front | sendToBackOnClick | Fix mark rotation to front | 167380034 | rchronowic | 2018-10-23T12:09:34Z | APPROVED | Spencer Childress | 2018-10-23T18:59:32Z | Tested this fix in both Firefox and Chrome, point rotation on click still functions properly and the drop down is now properly size! ;; All good to go! |
0115 | pburnsdata | 2019-01-08T21:14:35Z | pburnsdata-patch-1 | master | Resolve Spelling Error | NONE | Preston Burns | |||||
0116 | samussiah | 2019-02-07T15:33:48Z | dev-v2.5.0 | master | Safety Outlier Explorer v2.5.0 | 210383891 | danedexF5 | 2019-03-04T21:45:28Z | APPROVED | Preston Burns | 2019-03-05T18:14:16Z | Approved |
0117 | samussiah | 2019-02-07T16:56:51Z | invalid-starting-measure | dev-v2.5.0 | add starting measure check | 202871707 | pburnsdata | 2019-02-12T20:02:38Z | APPROVED | Spencer Childress | 2019-02-18T18:44:10Z | Looks good! Had trouble getting the branch/commit to load in CAT so tried it out locally - not sure yet why it wasn't working...;;yeah! |
0117 | samussiah | 2019-02-07T16:56:51Z | invalid-starting-measure | dev-v2.5.0 | add starting measure check | 204907947 | danedexF5 | 2019-02-18T18:07:19Z | APPROVED | Spencer Childress | 2019-02-18T18:44:10Z | |
0118 | samussiah | 2019-02-07T18:35:28Z | extend-y-domain | dev-v2.5.0 | extend y-domain | 202881020 | pburnsdata | 2019-02-12T20:17:07Z | APPROVED | Spencer Childress | 2019-02-18T18:44:17Z | noice - good idea to make it relative to the measure domain |
0118 | samussiah | 2019-02-07T18:35:28Z | extend-y-domain | dev-v2.5.0 | extend y-domain | 204908194 | danedexF5 | 2019-02-18T18:08:11Z | APPROVED | Spencer Childress | 2019-02-18T18:44:17Z | |
0119 | samussiah | 2019-02-07T23:06:45Z | add-y-increment | dev-v2.5.0 | precision | 202890680 | pburnsdata | 2019-02-12T20:31:09Z | APPROVED | Spencer Childress | 2019-02-18T18:44:27Z | Saweet. Much better than increments of 1;;this seemed reasonable for the examples I tried |
0119 | samussiah | 2019-02-07T23:06:45Z | add-y-increment | dev-v2.5.0 | precision | 204908150 | danedexF5 | 2019-02-18T18:07:58Z | APPROVED | Spencer Childress | 2019-02-18T18:44:27Z | |
0120 | samussiah | 2019-02-07T23:09:39Z | removed-records | dev-v2.5.0 | Removed records | 203781500 | pburnsdata | 2019-02-14T18:22:24Z | APPROVED | Spencer Childress | 2019-02-18T18:44:43Z | Awesome. Couldn't have made that any better;;Cool - good idea to clarify the reason for dropping;;fun lil test;;a nice touch |
0120 | samussiah | 2019-02-07T23:09:39Z | removed-records | dev-v2.5.0 | Removed records | 204908072 | danedexF5 | 2019-02-18T18:07:44Z | APPROVED | Spencer Childress | 2019-02-18T18:44:43Z | |
0121 | samussiah | 2019-02-12T21:35:52Z | custom-mark-highlighting | dev-v2.5.0 | Custom mark highlighting | 204001325 | pburnsdata | 2019-02-14T22:26:54Z | APPROVED | Spencer Childress | 2019-02-18T18:45:11Z | Alright, alright, alright. That's a wrap! LOOKIN GOOOD;;nice catch;;.....;;is default a method?;;MY MAN!!! YES! |
0121 | samussiah | 2019-02-12T21:35:52Z | custom-mark-highlighting | dev-v2.5.0 | Custom mark highlighting | 204907594 | samussiah | 2019-02-18T18:06:05Z | COMMENTED | Spencer Childress | 2019-02-18T18:45:11Z | i think that's how babel interprets import/export syntax in the context of require(). in this case the settings files return a default function. |
0121 | samussiah | 2019-02-12T21:35:52Z | custom-mark-highlighting | dev-v2.5.0 | Custom mark highlighting | 204908006 | danedexF5 | 2019-02-18T18:07:31Z | APPROVED | Spencer Childress | 2019-02-18T18:45:11Z | |
0123 | jwildfire | 2019-03-25T18:48:02Z | dev-v2.5.1 | master | v2.5.1 | 218523080 | samussiah | 2019-03-25T18:53:33Z | APPROVED | Spencer Childress | 2019-03-25T18:53:46Z | |
0124 | jwildfire | 2019-03-27T19:40:42Z | dev-v2.5.2 | master | dev-v2.5.2 | 220059749 | samussiah | 2019-03-28T14:34:16Z | APPROVED | Spencer Childress | 2019-03-28T14:34:21Z | |
0126 | samussiah | 2019-04-09T13:53:10Z | dev-v2.5.3 | master | Fix infinite loop calculating caused by zero range. | 224454374 | jwildfire | 2019-04-09T14:46:59Z | APPROVED | Spencer Childress | 2019-04-09T14:48:29Z | 👍 Logic looks good and worked with the sample data set where previous data was bombing. |
0133 | jwildfire | 2019-05-15T23:32:11Z | dev-v2.5.4 | master | Dev v2.5.4 | 239016546 | samussiah | 2019-05-17T16:21:33Z | CHANGES_REQUESTED | Spencer Childress | 2019-05-20T16:28:04Z | Minor issue with `details` update.;;Details in this chart are participant-level characteristics, not listing columns. Filters and measure characteristics don't make sense here. |
0133 | jwildfire | 2019-05-15T23:32:11Z | dev-v2.5.4 | master | Dev v2.5.4 | 239595436 | jwildfire | 2019-05-20T16:10:39Z | COMMENTED | Spencer Childress | 2019-05-20T16:28:04Z | That makes sense. Cleaning it up now. |
0133 | jwildfire | 2019-05-15T23:32:11Z | dev-v2.5.4 | master | Dev v2.5.4 | 239603617 | samussiah | 2019-05-20T16:27:38Z | APPROVED | Spencer Childress | 2019-05-20T16:28:04Z | prettier and their fickle opinions of code indentation... |
0134 | dependabot[bot] | 2019-07-12T19:32:52Z | dependabot/npm_and_yarn/lodash-4.17.14 | master | Bump lodash from 4.17.11 to 4.17.14 | 262466582 | samussiah | 2019-07-16T14:40:12Z | APPROVED | Spencer Childress | 2019-07-16T14:40:18Z | |
0137 | jwildfire | 2019-08-09T19:51:10Z | dev-v2.5.5 | master | Dev v2.5.5 | 276783925 | pburnsdata | 2019-08-19T20:04:00Z | APPROVED | jwildfire | 2019-08-19T20:07:20Z | Lookin good |
0138 | jwildfire | 2019-08-09T19:51:44Z | addCustomEvent | dev-v2.5.5 | Add custom event | 274986618 | pburnsdata | 2019-08-14T15:56:39Z | APPROVED | jwildfire | 2019-08-19T19:55:29Z | Looks good - might need to be updated with the new [overlapping points changes](https://github.com/RhoInc/safety-outlier-explorer/pull/140) I'm guessing that this will return each subject id as you cycle through by reclicking points. My current thought is that this is better than returning all the subjects under a point since you're still only viewing one line so it's fine as is - we just might want to add events for 2.6.0 to the ids the are listed beneath the chart when you click a point - that make sense @jwildfire? |
0139 | jwildfire | 2019-08-14T05:57:18Z | dev-v2.6.0 | master | Dev v2.6.0 | 278476529 | rchronowic | 2019-08-22T14:50:11Z | APPROVED | Spencer Childress | 2019-08-22T17:11:58Z | Passed regression testing. |
0140 | jwildfire | 2019-08-14T05:57:59Z | noverlap | dev-v2.6.0 | Deal with overlapping points | 276627069 | samussiah | 2019-08-19T15:11:09Z | APPROVED | jwildfire | 2019-08-19T20:30:47Z | This is way more functional and transparent than reordering the points in the DOM. Nice work. |
0142 | jwildfire | 2019-08-19T22:10:24Z | hoverlap | dev-v2.6.0 | Overlap tooltips | 277195757 | samussiah | 2019-08-20T14:11:31Z | APPROVED | jwildfire | 2019-08-20T15:32:51Z | Dig it. |
0144 | samussiah | 2020-01-31T16:28:15Z | dev-v2.6.1 | master | Safety Outlier Explorer v2.6.1 | 351626698 | jwildfire | 2020-01-31T16:33:38Z | APPROVED | jwildfire | 2020-01-31T16:34:08Z | |